Add gsk::RenderReplay bindings manually #2184
Open
+299
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A6GibKm
force-pushed
the
render-replay-bindings
branch
from
16cf7ee to
52c17e6
Compare
gsk4/src/render_replay.rs
Outdated
| impl RenderReplay { | ||
| #[doc(alias = "gsk_render_replay_default")] | ||
| #[allow(clippy::should_implement_trait)] | ||
| pub fn default(&mut self, node: impl AsRef<RenderNode>) -> Option<RenderNode> { |
Member
There was a problem hiding this comment.
I don't think any of those need &mut self
A6GibKm
force-pushed
the
render-replay-bindings
branch
2 times, most recently
from
13e5bfa to
31ed695
Compare
A6GibKm
force-pushed
the
render-replay-bindings
branch
3 times, most recently
from
8e972de to
3cec3c9
Compare
sdroege
reviewed
Nov 28, 2025
sdroege
reviewed
Nov 28, 2025
sdroege
reviewed
Nov 28, 2025
gsk4/src/render_replay.rs
Outdated
| } | ||
|
|
||
| #[doc(alias = "gsk_render_replay_set_node_foreach")] | ||
| pub fn set_node_foreach<P: Fn(&RenderReplay, &RenderNode) -> bool + 'static>( |
Member
There was a problem hiding this comment.
Suggested change
| pub fn set_node_foreach<P: Fn(&RenderReplay, &RenderNode) -> bool + 'static>( | |
| pub fn set_node_foreach<P: Fn(&RenderReplay, &RenderNode) -> glib::ControlFlow + 'static>( |
I think. The return value is whether to continue or break.
Contributor
Author
There was a problem hiding this comment.
* gsk_render_replay_set_node_foreach:
* @self: the replay
* @foreach: (nullable): the function to call for all nodes
* @user_data: user data to pass to @func
* @user_destroy: destroy notify that will be called to release
* user_data
*
* Sets the function to call for every node.
*
* This function is called before the node filter, so if it returns
* FALSE, the node filter will never be called.
I am not sure, but I left the code with ControlFlow for now.
sdroege
reviewed
Nov 28, 2025
sdroege
reviewed
Nov 28, 2025
sdroege
reviewed
Nov 28, 2025
sdroege
reviewed
Nov 28, 2025
Member
sdroege
left a comment
sdroege
left a comment
There was a problem hiding this comment.
Looks good to me apart from those details
A6GibKm
force-pushed
the
render-replay-bindings
branch
3 times, most recently
from
d52e5d8 to
7ed594f
Compare
Generated by temporarily adding glib:get-type to the gir file, moving the generated file to src and then - Replace the glib::wrapper macro with `struct` and `impl Drop`. - Replace from_glib_borrow with Self(ptr) - Replace to_glib_none_mut with self.0.as_mut
A6GibKm
force-pushed
the
render-replay-bindings
branch
3 times, most recently
from
834d30b to
360024c
Compare
A6GibKm
force-pushed
the
render-replay-bindings
branch
from
360024c to
e32fbaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated by temporarily adding glib:get-type to the gir file, moving he
generated file to src and modifying the glib::wrapper macro.
This is based on top of #2183.